linux-kernel - Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Oct 2010 15:54:25 +0100
From:	David Howells <dhowells@...hat.com>
To:	"Jan Beulich" <JBeulich@...ell.com>
Cc:	dhowells@...hat.com, akpm@...ux-foundation.org, torvalds@...l.org,
	"Ingo Molnar" <mingo@...e.hu>,
	"Alexander van Heukelum" <heukelum@...tmail.fm>,
	"H. Peter Anvin" <hpa@...ux.intel.com>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets

Jan Beulich <JBeulich@...ell.com> wrote:

> Isn't this a gas bug then? Anywhere you use a plain number you
> should also be permitted to use an expression.

Whoever defined the gas assembly syntax for binutils specified that (N) as an
operand defines an absolute address and N defines an immediate value.

However, prefixing an expression with a unary plus works for me, so adding
this into my patch:

-	s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \
+	s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 +(\2) /* \3 */:; \

Does that work for you?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/