linux-kernel - Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=mpKRQgZp5zCoCsBtkuWHrpkOq2Zch-OOGu4CC@mail.gmail.com>
Date:	Mon, 25 Oct 2010 08:17:12 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jan Beulich <JBeulich@...ell.com>
Cc:	Alexander van Heukelum <heukelum@...tmail.fm>,
	Ingo Molnar <mingo@...e.hu>, akpm@...ux-foundation.org,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	David Howells <dhowells@...hat.com>,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers
 in brackets

On Mon, Oct 25, 2010 at 8:05 AM, Jan Beulich <JBeulich@...ell.com> wrote:
>
> Alexander, you seem to be having access to a worst case system -
> could you give this a try?

This all seems very wrong.

The whole "add parenthesis" seems to break several architectures
(Power apparently had problems too due to redefining one of the
macros), and it is ugly.

And the whole thing was added for some stupid gas bug for a very
specific case, and now we're adding _more_ crap to an already ugly
workaround.

How about just removing the idiotic workaround entirely, and then on
x86 passing "-traditional" to cpp for asm input so that it doesn't add
spaces in argument expansion? Make the workaround more targeted to the
actual problem, rather than working around it in some unrelated
thing..

                                       Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/