linux-kernel - Re: [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC6C941.2080003@kernel.org>
Date:	Tue, 26 Oct 2010 14:27:45 +0200
From:	Tejun Heo <tj@...nel.org>
To:	David Howells <dhowells@...hat.com>
CC:	torvalds@...l.org, akpm@...ux-foundation.org,
	linux-am33-list@...hat.com, linux-kernel@...r.kernel.org,
	Akira Takeuchi <takeuchi.akr@...panasonic.com>,
	Mark Salter <msalter@...hat.com>
Subject: Re: [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues

On 10/26/2010 02:14 PM, Tejun Heo wrote:
>>> That said, I think it might be better to just remove the alignment parameter
>>> from the macro and force align to PAGE_SIZE.
>>
>> That's not necessarily good.  Two arches to note:
>>
>> 	arch/x86/kernel/vmlinux.lds.S:  PERCPU(THREAD_SIZE)
> 
> I don't think the current percpu allocator honors alignment larger
> than PAGE_SIZE no matter how large the alignment for the percpu output
> section is.  I'll look into it deeper but I think we might just have
> been lucky and the alignment somehow didn't bite us yet.  The only
> user of THREAD_SIZE mask at this point seems to be cpu_init().  Maybe
> we can remove this requirement.  I'll look into it.

Okay, this was added by commit fe8e0c2 in this merge window.  It's
broken and needs to be reverted.  I'll send a patch to revert it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/