linux-kernel - Re: [PATCH] ipmi: Run a dummy command before submitting a new command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Oct 2010 18:45:40 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Corey Minyard <cminyard@...sta.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: Run a dummy command before submitting a new
	command

I've finally had time to look at this more closely. The following patch 
seems to make things happy, but I still don't have a full understanding 
of what's going on.

(Background: Some HP ilo firmware versions are unhappy due to 
3326f4f2276791561af1fd5f2020be0186459813 . Running a dummy command in 
schedule() works around this but clearly isn't the right answer. Turns 
out that this also breaks IPMI on some Suns, and Oracle reverted this in 
their kernel but never told me. Thoracle)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index e537610..763af8f 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -901,6 +901,8 @@ static void sender(void                *send_info,

 	mod_timer(&smi_info->si_timer, jiffies + SI_TIMEOUT_JIFFIES);

+	smi_info->last_timeout_jiffies = jiffies;
+
 	if (smi_info->thread)
 		wake_up_process(smi_info->thread);

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/