linux-kernel - Re: [PATCH 08/29] memstick: mspro: add comments to few functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288058066.4024.108.camel@maxim-laptop>
Date:	Tue, 26 Oct 2010 03:54:26 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Alex Dubov <oakad@...oo.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/29] memstick: mspro: add comments to few functions

On Mon, 2010-10-25 at 08:18 -0700, Alex Dubov wrote:
> --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@...il.com> wrote:
> 
> > From: Maxim Levitsky <maximlevitsky@...il.com>
> > Subject: [PATCH 08/29] memstick: mspro: add comments to few functions
> > To: "Alex Dubov" <oakad@...oo.com>
> > Cc: "Andrew Morton" <akpm@...ux-foundation.org>, "LKML" <linux-kernel@...r.kernel.org>, "Maxim Levitsky" <maximlevitsky@...il.com>
> > Received: Friday, 22 October, 2010, 4:53 PM
> > a comment before function is not only
> > a good way
> > to give some information to the reader, but
> > it serves as a good anchor point for diff so that
> > it doesn't produce a diff between different
> > functions (sigh...)
> > 
> 
> Comments of new functions belong to the patch which introduces these new
> functions. And those functions (as I already said) belong to the patch
> which introduces new functionality, using these functions, desirably,
> one function at a time.
You did read the patch didn't you?
I added few comments to _existing_ functions something that code really
needs.
I also did explain why did I do that here, didn't I?
It makes next patch cleaner, as diff doesn't attempt to create a diff
between different functions.


-- 
Best regards,
        Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/