linux-kernel - Re: [PATCH v2 08/11] qla4xxx: Remove host_lock unlock() + lock() from qla4xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Oct 2010 18:57:00 -0700
From:	Ravi Anand <ravi.anand@...gic.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
CC:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Vasu Dev <vasu.dev@...ux.intel.com>,
	Tim Chen <tim.c.chen@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	James Bottomley <James.Bottomley@...e.de>,
	Mike Christie <michaelc@...wisc.edu>,
	James Smart <james.smart@...lex.com>,
	Andrew Vasquez <andrew.vasquez@...gic.com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Hannes Reinecke <hare@...e.de>,
	Joe Eykholt <jeykholt@...co.com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2 08/11] qla4xxx: Remove host_lock unlock() + lock()
 from qla4xxx_queuecommand()



On Fri, 17 Sep 2010, Nicholas A. Bellinger wrote:

> From: Nicholas Bellinger <nab@...ux-iscsi.org>
> 
> This patch removes the now legacy host_lock unlock() + lock() optimization
> from ql4_os.c:qla4xxx_queuecommand()
> 
> Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index 370d40f..cfbe8b5 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -511,26 +511,20 @@ static int qla4xxx_queuecommand(struct scsi_cmnd *cmd,
>  	    test_bit(DPC_RESET_HA_FW_CONTEXT, &ha->dpc_flags))
>  		goto qc_host_busy;
>  
> -	spin_unlock_irq(ha->host->host_lock);
> -
>  	srb = qla4xxx_get_new_srb(ha, ddb_entry, cmd, done);
>  	if (!srb)
> -		goto qc_host_busy_lock;
> +		goto qc_host_busy;
>  
>  	rval = qla4xxx_send_command_to_isp(ha, srb);
>  	if (rval != QLA_SUCCESS)
>  		goto qc_host_busy_free_sp;
>  
> -	spin_lock_irq(ha->host->host_lock);
>  	return 0;
>  
>  qc_host_busy_free_sp:
>  	qla4xxx_srb_free_dma(ha, srb);
>  	mempool_free(srb, ha->srb_mempool);
>  
> -qc_host_busy_lock:
> -	spin_lock_irq(ha->host->host_lock);
> -
>  qc_host_busy:
>  	return SCSI_MLQUEUE_HOST_BUSY;
>  

Let us know if you want us to send it to James
as part of our patch posting. Thanks.

Acked-by: Ravi Anand <ravi.anand@...gic.com>
> -- 
> 1.7.2.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/