linux-kernel - Re: [PATCH 28/49] tty: Add a new file /proc/tty/consoles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC7F616.5060404@suse.cz>
Date:	Wed, 27 Oct 2010 11:51:18 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Al Viro <viro@...IV.linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
	"Dr. Werner Fink" <werner@...e.de>
Subject: Re: [PATCH 28/49] tty: Add a new file /proc/tty/consoles

On 10/27/2010 11:27 AM, Dr. Werner Fink wrote:
> Such a list would be very helpful e.g. to extend sulogin
> to be able to prompt for maintenance on all terminal lines
> of the system console after e.g. failed fsck.  Currently
> only the preferred terminal line is prompted for maintenance.

I think nobody objects to the /proc/tty/consoles. This is a good thing
to have. The patch just needs to be fixed (and you already did and sent
me in private).

The objections are against the way how you find out the real tty behind
/dev/console. The method to walk through fd, guessing private_data etc.
is simply unacceptable.

Actually couldn't you just use one of:
1) ttyprintk driver (well, this will insert mess into klog)
2) send the output to all enabled consoles in /proc/tty/consoles
?

regards,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/