linux-kernel - Re: [PATCH 06/30] staging/vme/tsi148: use list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC7F635.6090005@ge.com>
Date:	Wed, 27 Oct 2010 10:51:49 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	"Emilio G. Cota" <cota@...ap.org>
CC:	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org,
	Juan David Gonzalez Cobas <david.cobas@...il.com>,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH 06/30] staging/vme/tsi148: use list_for_each_safe when
 deleting resources in .remove

On 26/10/10 02:10, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@...ap.org>
> 
> This fixes an oops when removing the module.
> 
> Signed-off-by: Emilio G. Cota <cota@...ap.org>

Acked-by: Martyn Welch <martyn.welch@...com>

> ---
>  drivers/staging/vme/bridges/vme_tsi148.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index e341122..660968e 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -2532,6 +2532,7 @@ err_struct:
>  static void tsi148_remove(struct pci_dev *pdev)
>  {
>  	struct list_head *pos = NULL;
> +	struct list_head *tmplist;
>  	struct vme_master_resource *master_image;
>  	struct vme_slave_resource *slave_image;
>  	struct vme_dma_resource *dma_ctrlr;
> @@ -2590,21 +2591,21 @@ static void tsi148_remove(struct pci_dev *pdev)
>  	tsi148_crcsr_exit(tsi148_bridge, pdev);
>  
>  	/* resources are stored in link list */
> -	list_for_each(pos, &tsi148_bridge->dma_resources) {
> +	list_for_each_safe(pos, tmplist, &tsi148_bridge->dma_resources) {
>  		dma_ctrlr = list_entry(pos, struct vme_dma_resource, list);
>  		list_del(pos);
>  		kfree(dma_ctrlr);
>  	}
>  
>  	/* resources are stored in link list */
> -	list_for_each(pos, &tsi148_bridge->slave_resources) {
> +	list_for_each_safe(pos, tmplist, &tsi148_bridge->slave_resources) {
>  		slave_image = list_entry(pos, struct vme_slave_resource, list);
>  		list_del(pos);
>  		kfree(slave_image);
>  	}
>  
>  	/* resources are stored in link list */
> -	list_for_each(pos, &tsi148_bridge->master_resources) {
> +	list_for_each_safe(pos, tmplist, &tsi148_bridge->master_resources) {
>  		master_image = list_entry(pos, struct vme_master_resource,
>  			list);
>  		list_del(pos);


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square,
Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/