linux-kernel - Re: [PATCH v3] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimgCS=U3wzoOtZhtFe0skJtuOaKA+bp+gYc5+qS@mail.gmail.com>
Date:	Wed, 27 Oct 2010 09:15:53 -0400
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Ralf Baechle <ralf@...ux-mips.org>, linux-i2c@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Ben Dooks <ben-linux@...ff.org>,
	srinidhi kasagar <srinidhi.kasagar@...ricsson.com>,
	Tomoya MORINAGA <morinaga526@....okisemi.com>,
	Wang Qi <qi.wang@...el.com>,
	Wang Yong Y <yong.y.wang@...el.com>, kok.howg.ewe@...el.com,
	joel.clark@...el.com, andrew.chih.howe.khor@...el.com
Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36

2010/10/26 Jean Delvare <khali@...ux-fr.org>:
> On Tue, 26 Oct 2010 18:47:37 +0900, Tomoya MORINAGA wrote:
>> Must we get Intel's signature ?
>> We have already got the following. Isn't  this enough ?
>> > Reviewed-by: Linus Walleij <linus.walleij@...ricsson.com>
>>
>> Though I haven't heard like the requirement,
>> if Intel's signature is mandatory, I will request to Intel.
>
> It's not mandatory, but the time Ben and myself have to review new
> drivers is scarce, so it's in your own interest to have the code
> reviewed by people with more time and more interest in the specific
> hardware.

I agree. My Reviewed-by is mainly about the code structure,
a few antipatterns were removed and it looks nice to me now.
We indeed need someone who knows the hardware to look at this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/