linux-kernel - Re: [PATCH] V4L/DVB: tea6415c: return -EIO if i2c_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201011011413.37411.hverkuil@xs4all.nl>
Date:	Mon, 1 Nov 2010 14:13:37 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Axel Lin <axel.lin@...il.com>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] V4L/DVB: tea6415c: return -EIO if i2c_check_functionality fails

On Monday, November 01, 2010 10:25:39 Axel Lin wrote:
> If the adapter does not support I2C_FUNC_SMBUS_WRITE_BYTE,
> return -EIO instead of 0.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Hans Verkuil <hverkuil@...all.nl>

> ---
>  drivers/media/video/tea6415c.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/tea6415c.c b/drivers/media/video/tea6415c.c
> index 3e99cea..19621ed 100644
> --- a/drivers/media/video/tea6415c.c
> +++ b/drivers/media/video/tea6415c.c
> @@ -148,7 +148,7 @@ static int tea6415c_probe(struct i2c_client *client,
>  
>  	/* let's see whether this adapter can support what we need */
>  	if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WRITE_BYTE))
> -		return 0;
> +		return -EIO;
>  
>  	v4l_info(client, "chip found @ 0x%x (%s)\n",
>  			client->addr << 1, client->adapter->name);
> 

-- 
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/