linux-kernel - Re: [PATCH 04/39] arch/powerpc: Update WARN uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288622509.366.237.camel@Joe-Laptop>
Date:	Mon, 01 Nov 2010 07:41:49 -0700
From:	Joe Perches <joe@...ches.com>
To:	michael@...erman.id.au
Cc:	Jiri Kosina <trivial@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/39] arch/powerpc: Update WARN uses

On Mon, 2010-11-01 at 22:02 +1100, Michael Ellerman wrote:
> On Sat, 2010-10-30 at 14:08 -0700, Joe Perches wrote:
> > Coalesce long formats.
> > Align arguments.
> > Add missing newlines.
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > ---
> >  arch/powerpc/kernel/hw_breakpoint.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c
> > index 5ecd040..d7343a7 100644
> > --- a/arch/powerpc/kernel/hw_breakpoint.c
> > +++ b/arch/powerpc/kernel/hw_breakpoint.c
> > @@ -270,8 +270,8 @@ int __kprobes hw_breakpoint_handler(struct die_args *args)
> >  	 * message to let the user know about it.
> >  	 */
> >  	if (!stepped) {
> > -		WARN(1, "Unable to handle hardware breakpoint. Breakpoint at "
> > -			"0x%lx will be disabled.", info->address);
> > +		WARN(1, "Unable to handle hardware breakpoint. Breakpoint at 0x%lx will be disabled.\n",
> > +		     info->address);
> 
> That appears to have done nothing other than turn a short line into one
> that is now > 80 columns.

Added '\n'.

The series was done for a few reasons:

o to add missing newlines at the end of messages as was done here
o to convert a couple of misuses of WARN(msg) to WARN(1, msg)
o to remove KERN_ prefixes from WARN(test, KERN_<level> msg)

>  Is that the latest fad?

Pretty much.  Format coalescing is generally preferred for grep.
Some consider it churn.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/