linux-kernel - [PATCH v2] AMD Microcode: Prefer vzalloc() over calls to vmalloc()+memset().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Nov 2010 22:44:34 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Borislav Petkov <bp@...en8.de>
cc:	linux-kernel@...r.kernel.org, Peter Oruba <peter.oruba@....com>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	amd64-microcode@...64.org
Subject: [PATCH v2] AMD Microcode: Prefer vzalloc() over calls to
 vmalloc()+memset().

On Mon, 1 Nov 2010, Borislav Petkov wrote:

> On Mon, Nov 01, 2010 at 08:23:23PM +0100, Jesper Juhl wrote:
> > Thank you for the feedback I'll prepare a new version of the patch 
> > incorporating it, then resend it. 
> > 
> > One thing I'm not entirely sure about though is how to credit you with 
> > your improment to my original patch. Would I simply prepend
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> > Signed-off-by: Borislav Petkov <bp@...en8.de>
> > 
> > or should I leave just my own Signed-off-by: and then mention you in the 
> > changelog part of the mail or? 
> 
> How very considerate of you, but no need. Simply put your SOB in and
> I'll ack it.
> 
Ok. I just care a great deal about assigning credit where due, since for 
some of us (me included) the only credit we ever get for our work is the 
small credit attributed to us via the SOB or similar... But, I'll just 
(almost) respin the patch with just my own SOB below.



We don't have to do memset() ourselves after vmalloc() when we have 
vzalloc(), so change that in 
arch/x86/kernel/microcode_amd.c::get_next_ucode().
Thanks to Borislav Petkov for improvement suggestions.


Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
 microcode_amd.c |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
index e1af7c0..383d4f8 100644
--- a/arch/x86/kernel/microcode_amd.c
+++ b/arch/x86/kernel/microcode_amd.c
@@ -183,16 +183,17 @@ get_next_ucode(const u8 *buf, unsigned int size, unsigned int *mc_size)
 		return NULL;
 	}
 
-	mc = vmalloc(UCODE_MAX_SIZE);
-	if (mc) {
-		memset(mc, 0, UCODE_MAX_SIZE);
-		if (get_ucode_data(mc, buf + UCODE_CONTAINER_SECTION_HDR,
-				   total_size)) {
-			vfree(mc);
-			mc = NULL;
-		} else
-			*mc_size = total_size + UCODE_CONTAINER_SECTION_HDR;
+	mc = vzalloc(UCODE_MAX_SIZE);
+	if (!mc)
+		return NULL;
+
+	if (get_ucode_data(mc, buf + UCODE_CONTAINER_SECTION_HDR, total_size)) {
+		vfree(mc);
+		mc = NULL;
+	} else {
+		*mc_size = total_size + UCODE_CONTAINER_SECTION_HDR;
 	}
+
 	return mc;
 }
 


-- 
Jesper Juhl <jj@...osbits.net>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/