[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101101234630.GA12106@electric-eye.fr.zoreil.com>
Date: Tue, 2 Nov 2010 00:46:30 +0100
From: Francois Romieu <romieu@...zoreil.com>
To: Daniel J Blueman <daniel.blueman@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [2.6.37-rc1, patch] r8169: fix sleeping while holding spinlock...
Daniel J Blueman <daniel.blueman@...il.com> :
> Recent changes to the r8169 driver cause it to call
> device_set_wakeup_enable under spinlock, which may sleep.
The change is fine but the description is misleading : the r8169
driver has been issuing device_set_wakeup_enable under spinlock since
october 2008. device_set_wakeup_enable did not sleep until recently
(see f2dc0d1809ab7e0147c7e4ac837be1682f706538 for instance).
drivers/net/gianfar_ethtool.c::gfar_set_wol is broken as well when
CONFIG_PM is set.
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists