linux-kernel - Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101102122413.GJ840@cmpxchg.org>
Date:	Tue, 2 Nov 2010 08:24:13 -0400
From:	Johannes Weiner <hannes@...xchg.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Pavel Emelianov <xemul@...nvz.org>,
	Minchan Kim <minchan.kim@...il.com>,
	Paul Menage <menage@...gle.com>,
	Li Zefan <lizf@...fujitsu.com>,
	containers@...ts.linux-foundation.org
Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in
 memory controller code.

On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote:
> On Mon, 1 Nov 2010, Johannes Weiner wrote:
> 
> > On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote:
> > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then 
> > > followed by memset() to zero the memory. This can be more efficiently 
> > > achieved by using kzalloc() and vzalloc().
> > > 
> > > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> > 
> > Looks good to me, but there is also the memset after kmalloc in
> > alloc_mem_cgroup_per_zone_info().  Can you switch that over as well
> > in this patch?  You can pass __GFP_ZERO to kmalloc_node() for zeroing.
>
> Sure thing.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Thanks.

Reviewed-by: Johannes Weiner <hannes@...xchg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/