linux-kernel - Re: [DRAFT PATCH 0/3] perf: Add Intel Nehalem uncore pmu support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288700970.2039.26.camel@laptop>
Date:	Tue, 02 Nov 2010 13:29:30 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Lin Ming <ming.m.lin@...el.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Stephane Eranian <eranian@...gle.com>, robert.richter@....com,
	Cyrill Gorcunov <gorcunov@...il.com>, paulus@...ba.org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	CoreyAshford <cjashfor@...ux.vnet.ibm.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [DRAFT PATCH 0/3] perf: Add Intel Nehalem uncore pmu support

On Tue, 2010-11-02 at 15:27 +0800, Lin Ming wrote:
> Any comment is very appreciated.

Right, so I was hoping to use the sysfs bits to expose things, I'll try
and get around to looking at your latest effort in that area soonish.
I'll try and sit down with gregkh one of these days to talk it over.

I'm not too sure about 1/3's change to x86_perf_event_update(), but its
not too aweful, the change to x86_perf_event_set_period() however does
look quite gruesome.

It might make sense to simple duplicate that code in the uncore bits,.
dunno.

2/3 looks ok, but I think it would be nice if it would be more self
contained, that is, not be part of the include mess and possibly have
its own NMI_DIE notifier entry.

All in all, Thanks for doing this, its a good start!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/