linux-kernel - Re: [PATCH] staging: frontier: alphatrack: fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Nov 2010 08:37:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	Audun Hoem <audun.hoem@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: frontier: alphatrack: fixed coding style
 issues

On Tue, 2010-11-02 at 16:31 +0100, Audun Hoem wrote:
> Cleaned up a macro definition and another simple style warning.
> Signed-off-by: Audun Hoem <audun.hoem@...il.com>
> ---
>  drivers/staging/frontier/alphatrack.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier/alphatrack.c
> index ef7fbf8..6e3bd73 100644
> --- a/drivers/staging/frontier/alphatrack.c
> +++ b/drivers/staging/frontier/alphatrack.c
> @@ -88,8 +88,11 @@ MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface");
>  static int debug = ALPHATRACK_DEBUG;
>  
>  /* Use our own dbg macro */
> -#define dbg_info(dev, format, arg...) do \
> -    { if (debug) dev_info(dev , format , ## arg); } while (0)
> +#define dbg_info(dev, format, arg...) \
> +do { \
> +	if (debug) \
> +		dev_info(dev , format , ## arg); \

There is no need for the spaces before commas.

gcc 2.xx required a space before a comma with a trailing ##arg,
but that compiler version is no longer supported.

This should be:
	dev_info(dev, format, ##arg);

though I think using dev_dbg and getting rid of the dbg_info
macro is better.

> +} while (0)
>  
>  #define alphatrack_ocmd_info(dev, cmd, format, arg...)
>  
> @@ -769,7 +772,7 @@ static int usb_alphatrack_probe(struct usb_interface *intf,
>  	}
>  
>  	dev->write_buffer =
> -	    kmalloc(sizeof(struct alphatrack_ocmd) * true_size, GFP_KERNEL);
> +	    kmalloc(sizeof(struct alphatrack_ocmd) *true_size, GFP_KERNEL);

Not an improvement.

If checkpatch warns about this, it's a checkpatch defect.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/