linux-kernel - Re: [PATCH] tty: fix typos/errors in tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CCFBF8F.6090906@suse.cz>
Date:	Tue, 02 Nov 2010 08:36:47 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Timur Tabi <timur@...escale.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: fix typos/errors in tty_driver.h comments

On 11/01/2010 04:38 PM, Timur Tabi wrote:
> Fix various typos and other errors in comments of tty_driver.h.  The most
> significant is the wrong name of a function for the description of
> TTY_DRIVER_DYNAMIC_DEV.
> 
> Signed-off-by: Timur Tabi <timur@...escale.com>

ACK, but you should CC maintainer (Greg KH).

> ---
>  include/linux/tty_driver.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
> index b086779..6c4e42f 100644
> --- a/include/linux/tty_driver.h
> +++ b/include/linux/tty_driver.h
> @@ -102,7 +102,7 @@
>   * 	    unsigned int cmd, unsigned long arg);
>   *
>   * 	This routine allows the tty driver to implement
> - *	device-specific ioctl's.  If the ioctl number passed in cmd
> + * 	device-specific ioctls.  If the ioctl number passed in cmd
>   * 	is not recognized by the driver, it should return ENOIOCTLCMD.
>   *
>   *	Optional
> @@ -167,12 +167,12 @@
>   * 
>   * void (*hangup)(struct tty_struct *tty);
>   *
> - * 	This routine notifies the tty driver that it should hangup the
> + * 	This routine notifies the tty driver that it should hang up the
>   * 	tty device.
>   *
>   *	Optional:
>   *
> - * int (*break_ctl)(struct tty_stuct *tty, int state);
> + * int (*break_ctl)(struct tty_struct *tty, int state);
>   *
>   * 	This optional routine requests the tty driver to turn on or
>   * 	off BREAK status on the RS-232 port.  If state is -1,
> @@ -348,7 +348,7 @@ static inline struct tty_driver *tty_driver_kref_get(struct tty_driver *d)
>   * 	overruns, either.)
>   *
>   * TTY_DRIVER_DYNAMIC_DEV --- if set, the individual tty devices need
> - *	to be registered with a call to tty_register_driver() when the
> + *	to be registered with a call to tty_register_device() when the
>   *	device is found in the system and unregistered with a call to
>   *	tty_unregister_device() so the devices will be show up
>   *	properly in sysfs.  If not set, driver->num entries will be


-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/