[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTikq_D_HjMG0kSqTNc4aoFhtN71usVcNGGz2pAn4@mail.gmail.com>
Date: Tue, 2 Nov 2010 03:35:30 -0400
From: Mike Frysinger <vapier.adi@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: michael.hennerich@...log.com, drivers@...log.com,
sfr@...b.auug.org.au, linux-kernel@...r.kernel.org,
linux-next@...r.kernel.org, rpurdie@...ux.intel.com,
device-drivers-devel@...ckfin.uclinux.org
Subject: Re: [Device-drivers-devel] [PATCH] video: backlight: adp8870: Fix
warn_unused_result warning reported by Stephen Rothwell
On Fri, Oct 29, 2010 at 15:25, Andrew Morton wrote:
>> Subject: [PATCH] video: backlight: adp8870: Fix warn_unused_result warning reported by Stephen Rothwell
>
> Lots of people are doing this "video: backlight: adp8870:" thing
> lately. And it's good, but why not just use
> "drivers/video/backlight/adp8860_bl.c" to identify the affected
> susbsytem/file/etc? It's simple and uniform. It's not always the
> appropriate thing to do, but replacing the /'s with ": " seems rather
> random and pointless.
the colons and spaces make it a lot easier to pick out in a git log.
your suggestion makes it much harder to read due to the lack of
whitespace.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists