linux-kernel - Re: [PATCH] KVM x86: remove memset, use vzalloc and don't assign the same value to a variable twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101103124711.GB16809@amt.cnet>
Date:	Wed, 3 Nov 2010 10:47:11 -0200
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Takuya Yoshikawa <yoshikawa.takuya@....ntt.co.jp>,
	kvm@...r.kernel.org, Avi Kivity <avi@...hat.com>,
	linux-kernel@...r.kernel.org, Alexander Graf <agraf@...e.de>
Subject: Re: [PATCH] KVM x86: remove memset, use vzalloc and don't assign the
 same value to a variable twice

On Tue, Nov 02, 2010 at 05:11:19AM +0100, Jesper Juhl wrote:
> On Tue, 2 Nov 2010, Takuya Yoshikawa wrote:
> 
> > Hi Jesper, (dropped some addresses from Cc)
> > 
> > > > Jesper Juhl wrote:
> > > There's definately a positive size impact for the generated object code 
> > > and we save having to do the call to memset() and the cost of a vzalloc() 
> > > call looks more or less the same as a call to vmalloc() to me.
> > 
> > > > This patch is not based on kvm.git, I guess.
> > > > 
> > > Nope. It was generated against mainline git as of a couple of days ago. I 
> > > can generate a version against kvm.git if you prefer.
> > 
> > Sorry, I should have said more clearly.
> > 
> > kvm_vm_ioctl_get_dirty_log() has been changed since latest mainline kernel was released.
> > Furthermore, vmalloc() in it is to be removed soon, currently in kvm's next.
> > 
> > I have checked all vmalloc() + memset() in kvm, and there are three remaining.
> > See the patch below.
> >   - I have tested on x86.
> >   - I can test ppc later if needed, but this is so trivial that Alex will see
> >     no problem about this, probably.
> > 
> > So please write your Signed-off-by and ask Avi and Marcelo to apply.
> > 
> > Thanks,
> >   Takuya
> > 
> > ===
> > Subject: [PATCH] KVM: replace vmalloc and memset with vzalloc
> > 
> > Let's use newly introduced vzalloc().
> > 
> > Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@....ntt.co.jp>
> 
> Signed-off-by: Jesper-juhl <jj@...osbits.net>

Applied, thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/