linux-kernel - Re: [PATCH] regulator: Staticise mc13783_powermisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Nov 2010 14:50:08 +0100
From:	Alberto Panizzo <maramaopercheseimorto@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Liam Girdwood <lrg@...mlogic.co.uk>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: Staticise mc13783_powermisc_rmw()

On mer, 2010-11-03 at 00:08 -0400, Mark Brown wrote:
> It is not used outside this driver so no need to make the symbol global.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

It's OK for me, because no other functionalities than regulator's one
are influenced by the Power Misc register.

Acked-by: Alberto Panizzo <maramaopercheseimorto@...il.com>

> ---
>  drivers/regulator/mc13783-regulator.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
> index 5e6fa47..47ea999 100644
> --- a/drivers/regulator/mc13783-regulator.c
> +++ b/drivers/regulator/mc13783-regulator.c
> @@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
>  	.get_voltage = mc13783_fixed_regulator_get_voltage,
>  };
>  
> -int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> -									u32 val)
> +static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> +				 u32 val)
>  {
>  	struct mc13783 *mc13783 = priv->mc13783;
>  	int ret;


-- 
Alberto!

        Be Persistent!
                - Greg Kroah-Hartman (FOSDEM 2010)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/