linux-kernel - Re: [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CD12833.8060204@eukrea.com>
Date:	Wed, 03 Nov 2010 10:15:31 +0100
From:	Eric Bénard <eric@...rea.com>
To:	Dinh.Nguyen@...escale.com
CC:	linux-kernel@...r.kernel.org, amit.kucheria@...onical.com,
	linux@....linux.org.uk, s.hauer@...gutronix.de,
	grant.likely@...retlab.ca, linux-arm-kernel@...ts.infradead.org,
	daniel@...aq.de, u.kleine-koenig@...gutronix.de,
	xiao-lizhang@...escale.com, valentin.longchamp@...l.ch
Subject: Re: [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions.

Hi Dinh,

Le 02/11/2010 23:17, Dinh.Nguyen@...escale.com a écrit :
> From: Dinh Nguyen<Dinh.Nguyen@...escale.com>
>
> Add mx53 support to cpu.c and mm.c.
>
> Signed-off by: Dinh Nguyen<Dinh.Nguyen@...escale.com>
>   static void query_silicon_parameter(void)
>   {
> -	void __iomem *rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> +	void __iomem *rom;
>   	u32 rev;
>
> +	if (cpu_is_mx51())
> +		rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> +	else if (cpu_is_mx53())
> +		rom = ioremap(MX53_IROM_BASE_ADDR, MX53_IROM_SIZE);
> +
isn't the correct way to get the silicon revision to read the "Product 
Revision register" and "Silicon Revision register" of the IIM and not from the 
internal ROM ? (page 41-11 of the i.MX51 reference manual).

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/