linux-kernel - Re: [RFC/RFT] OHCI: Fix for regression in 2.6.37-rc1 since commit 3df7169e7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CD20820.1070406@lwfinger.net>
Date:	Wed, 03 Nov 2010 20:10:56 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	pali.rohar@...il.com, Greg Kroah-Hartman <gregkh@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC/RFT] OHCI: Fix for regression in 2.6.37-rc1 since commit
 3df7169e7

On 11/03/2010 04:04 PM, Alan Stern wrote:
> 
> This patch is definitely wrong -- it defeats the entire purpose of 
> rewriting the control register!  That write was added _specifically_ to 
> put the controller into reset, i.e., to change the functional state.
> 
> Furthermore, the write does the same thing as ohci_hcd.c does in its
> ohci_usb_reset() routine.  Regardless, ohci_run() does a complete host
> controller reset, which should override anything done in pci-quirks.c.  
> Perhaps _that_ routine needs some attention.

It is looking as if your patch is exposing a different bug. When I disable the
write in pci_quirks leaving the controllers in OPER or RESUME mode, then
ohci_run() is not called. I'm still trying to find out why.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/