linux-kernel - Re: [PATCH 4/4] power_supply: isp1704: Detect charger after probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CD41E9D.2000702@ru.mvista.com>
Date:	Fri, 05 Nov 2010 18:11:25 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Heikki Krogerus <heikki.krogerus@...ia.com>
CC:	cbouatmailru@...il.com, dwmw2@...radead.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	ameya.palande@...ia.com, markus.lehtonen@...ia.com
Subject: Re: [PATCH 4/4] power_supply: isp1704: Detect charger after probe

Hello.

On 04-11-2010 17:31, Heikki Krogerus wrote:

> If the device is booted up with cable connected, or the
> module is loaded after plugging in the cable, the
> notification has come and gone, so not relying on it at
> probe time. Instead this checks the VBUS level manually
> after probe.

> Signed-off-by: Heikki Krogerus<heikki.krogerus@...ia.com>
> ---
>   drivers/power/isp1704_charger.c |   17 +++++++++++++++++
>   1 files changed, 17 insertions(+), 0 deletions(-)

> diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
> index 77c11f1..946e43c 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -422,6 +422,23 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
>
>   	dev_info(isp->dev, "registered with product id %s\n", isp->model);
>
> +	/*
> +	 * Taking over the D+ pullup.
> +	 *
> +	 * FIXME: The device will be disconnected if the it was already
                                                      ^^^
    "the" is not needed here.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/