linux-kernel - Re: [PATCH 4/4] power_supply: isp1704: Detect charger after probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101108102240.GA7451@esdhcp041123.research.nokia.com>
Date:	Mon, 8 Nov 2010 12:22:40 +0200
From:	Heikki Krogerus <heikki.krogerus@...ia.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	cbouatmailru@...il.com, dwmw2@...radead.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	ameya.palande@...ia.com, markus.lehtonen@...ia.com
Subject: Re: [PATCH 4/4] power_supply: isp1704: Detect charger after probe

Hi,

On Fri, Nov 05, 2010 at 04:11:25PM +0100, ext Sergei Shtylyov wrote:
> > @@ -422,6 +422,23 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
> >
> >   	dev_info(isp->dev, "registered with product id %s\n", isp->model);
> >
> > +	/*
> > +	 * Taking over the D+ pullup.
> > +	 *
> > +	 * FIXME: The device will be disconnected if the it was already
>                                                       ^^^
>     "the" is not needed here.

Here's the fix removing the extra "the". Thanks.

-- 
heikki

View attachment "0001-power_supply-isp1704-Detect-charger-after-probe.patch" of type "text/x-diff" (1579 bytes)