linux-kernel - Re: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201011071835.28692.fmhess@speakeasy.net>
Date:	Sun, 7 Nov 2010 18:35:23 -0500
From:	Frank Mori Hess <fmhess@...akeasy.net>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Gustavo Silva <silvagustavo@...rs.sourceforge.net>,
	Tejun Heo <tj@...nel.org>, Arun Thomas <arun.thomas@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Frank Mori Hess <fmhess@...rs.sourceforge.net>,
	"Chris R. Baugher" <baugher@...eract.com>,
	"David A. Schleef" <ds@...leef.org>
Subject: Re: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure

On Sunday 07 November 2010, Jesper Juhl wrote:
> Hi,
>
> In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many
> potential failure scenarios. However, the driver neglects to free
> resources it has allocated if failures happen.

This patch appears to be wrong.  The driver's detach function will be 
called by the core if the attach function returns with an error.  The 
resources are freed there.


Download attachment "signature.asc " of type "application/pgp-signature" (190 bytes)