lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Nov 2010 00:34:56 +0100 (CET) From: Jesper Juhl <jj@...osbits.net> To: Frank Mori Hess <fmhess@...rs.sourceforge.net> cc: linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org, Gustavo Silva <silvagustavo@...rs.sourceforge.net>, Tejun Heo <tj@...nel.org>, Arun Thomas <arun.thomas@...il.com>, Greg Kroah-Hartman <gregkh@...e.de>, "Chris R. Baugher" <baugher@...eract.com>, "David A. Schleef" <ds@...leef.org> Subject: Re: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure On Sun, 7 Nov 2010, Frank Mori Hess wrote: > On Sunday 07 November 2010, Jesper Juhl wrote: > > Hi, > > > > In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many > > potential failure scenarios. However, the driver neglects to free > > resources it has allocated if failures happen. > > This patch appears to be wrong. The driver's detach function will be > called by the core if the attach function returns with an error. The > resources are freed there. > Ohh, sorry, I did not realize that. In that case, please disregard this patch. -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists