linux-kernel - Re: [PATCH] mxcmmc: Add the ability to bind a regulator to manage the MMC card voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Nov 2010 11:03:08 +0100
From:	Alberto Panizzo <maramaopercheseimorto@...il.com>
To:	Linus Walleij <linus.ml.walleij@...il.com>
Cc:	Sascha Hauer <s.hauer@...gutronix.de>,
	Daniel Mack <daniel@...aq.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Eric Bénard <eric@...rea.com>,
	Fabio Estevam <fabioestevam@...oo.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] mxcmmc: Add the ability to bind a regulator to manage
 the MMC card voltage

On lun, 2010-11-08 at 23:12 +0100, Linus Walleij wrote:
> 2010/11/2 Alberto Panizzo <maramaopercheseimorto@...il.com>:
> 
> > +static inline void mxcmci_init_ocr(struct mxcmci_host *host)
> > +{
> > +#ifdef CONFIG_REGULATOR
> > +       host->vcc = regulator_get(mmc_dev(host->mmc), "vmmc");
> > +
> > +       if (IS_ERR(host->vcc)) {
> > +               host->vcc = NULL;
> > +       } else {
> > +               host->mmc->ocr_avail = mmc_regulator_get_ocrmask(host->vcc);
> > +               if (host->pdata && host->pdata->ocr_avail)
> > +                       dev_warn(mmc_dev(host->mmc),
> > +                               "pdata->ocr_avail will not be used\n");
> > +       }
> > +#endif
> 
> You don't need these #ifdef CONFIG_REGULATOR guardposts
> anymore. I implemented stub functions for the ocrmask functions
> for 2.6.37.

Ehm.. thank you really for pointing me this, because I've also used the
old API breaking the build in the -next branch..

A Fix will be posted as soon as possible!

Thanks Linus!
Best regards,

-- 
Alberto!

        Be Persistent!
                - Greg Kroah-Hartman (FOSDEM 2010)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/