lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Nov 2010 23:12:01 +0100 From: Linus Walleij <linus.ml.walleij@...il.com> To: Alberto Panizzo <maramaopercheseimorto@...il.com> Cc: Sascha Hauer <s.hauer@...gutronix.de>, Daniel Mack <daniel@...aq.de>, Andrew Morton <akpm@...ux-foundation.org>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Eric Bénard <eric@...rea.com>, Fabio Estevam <fabioestevam@...oo.com>, linux-kernel <linux-kernel@...r.kernel.org>, linux-mmc <linux-mmc@...r.kernel.org> Subject: Re: [PATCH] mxcmmc: Add the ability to bind a regulator to manage the MMC card voltage 2010/11/2 Alberto Panizzo <maramaopercheseimorto@...il.com>: > +static inline void mxcmci_init_ocr(struct mxcmci_host *host) > +{ > +#ifdef CONFIG_REGULATOR > + host->vcc = regulator_get(mmc_dev(host->mmc), "vmmc"); > + > + if (IS_ERR(host->vcc)) { > + host->vcc = NULL; > + } else { > + host->mmc->ocr_avail = mmc_regulator_get_ocrmask(host->vcc); > + if (host->pdata && host->pdata->ocr_avail) > + dev_warn(mmc_dev(host->mmc), > + "pdata->ocr_avail will not be used\n"); > + } > +#endif You don't need these #ifdef CONFIG_REGULATOR guardposts anymore. I implemented stub functions for the ocrmask functions for 2.6.37. > +static inline void mxcmci_set_power(struct mxcmci_host *host, unsigned int vdd) > +{ > +#ifdef CONFIG_REGULATOR > + if (host->vcc) > + mmc_regulator_set_ocr(host->vcc, vdd); > +#endif Neither here. But for both cases: no big deal. Take it the day it disturbs you :-) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists