linux-kernel - Re: [PATCH 6/6 v2] ARM: Add support for the display controllers in VT8500 and WM8505

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Nov 2010 13:23:29 +0300
From:	Alexey Charkov <alchark@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	vt8500-wm8505-linux-kernel@...glegroups.com,
	linux-arm-kernel@...ts.infradead.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Paul Mundt <lethal@...ux-sh.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Ralf Baechle <ralf@...ux-mips.org>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6 v2] ARM: Add support for the display controllers in
 VT8500 and WM8505

2010/11/8 Arnd Bergmann <arnd@...db.de>:
> On Sunday 07 November 2010, Alexey Charkov wrote:
>>  drivers/video/Kconfig         |   26 +++
>>  drivers/video/Makefile        |    3 +
>>  drivers/video/vt8500lcdfb.c   |  452 +++++++++++++++++++++++++++++++++++++++++
>>  drivers/video/vt8500lcdfb.h   |   34 +++
>>  drivers/video/wm8505fb.c      |  438 +++++++++++++++++++++++++++++++++++++++
>>  drivers/video/wm8505fb_regs.h |   76 +++++++
>>  drivers/video/wmt_ge_rops.c   |  186 +++++++++++++++++
>>  drivers/video/wmt_ge_rops.h   |    5 +
>
> From a very brief look, the two drivers look rather similar. What is the
> reason to have separate drivers instead of just one?
>
> Could you perhaps take the common parts and move them into a third module
> that exports symbols to be used by the two drivers?
>

Quite frankly, I would say that all SoC framebuffer drivers are quite
similar ;-) Register offsets, timing formats, accepted pixel formats,
buffer alignment requirements are all different, so I do not really
believe that there'd be much benefit from introducing another
abstraction level. This is open to debate, of course.

Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/