linux-kernel - Re: [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Nov 2010 12:10:13 -0800
From:	Joe Perches <joe@...ches.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] include/linux/kernel.h: Move logging bits to
 include/linux/logging.h

On Tue, 2010-11-09 at 22:01 +0200, Alexey Dobriyan wrote:
> On Tue, Nov 09, 2010 at 10:49:19AM -0800, Linus Torvalds wrote:
> > On Tue, Nov 9, 2010 at 10:43 AM, Joe Perches <joe@...ches.com> wrote:
> > >
> > > diff from V1 - Don't add pr_<level>_once macros
> > >
> > >  include/linux/kernel.h  |  244 +--------------------------------------
> > >  include/linux/logging.h |  295 +++++++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 296 insertions(+), 243 deletions(-)
> > >  create mode 100644 include/linux/logging.h
> > 
> > So where do the extra 53 lines come from now?
> > 
> > This still is clearly not just code movement, and it's impossible for
> > me to see what actually changed. Something must have.
> 
> Why linux_banner is moved?
> Why linux_proc_banner is moved?

It's only used by a printk.

> Why header is not named printk.h?

No particular reason nor any particular objection.

> Why random stuff like log_buf_kexec_setup() and hexdump is moved?

hexdump functions are logging message related
as is log_buf_kexec_setup.

hexdump should/will eventually have an
#ifdef CONFIG_PRINTK
	external function prototypes
#else
static inline void
hex_dump_to_buffer(const void *buf, size_t len,
		   int rowsize, int groupsize,
		   char *linebuf, size_t linebuflen, bool ascii) {}
static inline void
print_hex_dump(const char *level, const char *prefix_str,
	       int prefix_type, int rowsize, int groupsize,
	       const void *buf, size_t len, bool ascii) {}
static inline void
print_hex_dump_bytes(const char *prefix_str, int prefix_type,
		     const void *buf, size_t len) {}
#endif

so the static strings of the call sites can be eliminated
when !CONFIG_PRINTK.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/