linux-kernel - Re: [06/32] drivers/hwmon/asus_atk0110.c: Use pr_fmt and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=cTAGuCyk4S-1rscbMUmOm_6X43L7hQTBFmL4y@mail.gmail.com>
Date:	Tue, 9 Nov 2010 21:15:04 +0100
From:	Luca Tettamanti <kronos.it@...il.com>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	Joe Perches <joe@...ches.com>, Jean Delvare <khali@...ux-fr.org>,
	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [06/32] drivers/hwmon/asus_atk0110.c: Use pr_fmt and pr_<level>

On Tue, Nov 9, 2010 at 5:37 PM, Guenter Roeck
<guenter.roeck@...csson.com> wrote:
> On Wed, Oct 20, 2010 at 06:51:30AM -0000, Joe Perches wrote:
>> Added #define pr_fmt KBUILD_MODNAME ": " fmt
>> Converted printks to pr_<level>
>> Coalesced any long formats
>> Removed prefixes from formats
>>
>> Signed-off-by: Joe Perches <joe@...ches.com>
>>
> Applied.
>
> On a side note, I let the long lines go through as long as checkpatch doesn't complain.

I lost sight of the discussion, but I thought that a better solution
was to put the define for pr_fmt in a common header instead of
scattering it in all the drivers.

Luca
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/