linux-kernel - Re: [PATCH v2 12/23] netpoll: Introduce netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101109033024.GA5220@cr0.nay.redhat.com>
Date:	Tue, 9 Nov 2010 11:30:24 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Mike Waychison <mikew@...gle.com>
Cc:	simon.kagstrom@...insight.net, davem@...emloft.net,
	nhorman@...driver.com, Matt Mackall <mpm@...enic.com>,
	adurbin@...gle.com, linux-kernel@...r.kernel.org,
	chavey@...gle.com, Greg KH <greg@...ah.com>,
	Américo Wang <xiyou.wangcong@...il.com>,
	akpm@...ux-foundation.org, linux-api@...r.kernel.org
Subject: Re: [PATCH v2 12/23] netpoll: Introduce netpoll_target configs

On Mon, Nov 08, 2010 at 12:32:47PM -0800, Mike Waychison wrote:
>As preparation for moving netpoll_targets out of netconsole and making
>them available to other clients, introduce new Kconfig options.
>
>CONFIG_NETPOLL_TARGETS
>
>Access to targets APIs.  Only supports parameter based parsing of
>targets (via the kernel command line or module paramters).
>
>CONFIG_NETPOLL_TARGETS_DYNAMIC
>
>Extends the support that netpoll_targets provides by allowing for the
>dynamic creation of targets in configfs on a per client basis.
>
>Signed-off-by: Mike Waychison <mikew@...gle.com>
>---
> drivers/net/Kconfig      |   16 +++++++++++++---
> drivers/net/netconsole.c |   10 +++++-----
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>index f6668cd..b014cd6 100644
>--- a/drivers/net/Kconfig
>+++ b/drivers/net/Kconfig
>@@ -3367,14 +3367,15 @@ config NET_FC
> 
> config NETCONSOLE
> 	tristate "Network console logging support"
>+	select NETPOLL_TARGETS
> 	---help---
> 	If you want to log kernel messages over the network, enable this.
> 	See <file:Documentation/networking/netconsole.txt> for details.
> 
> config NETCONSOLE_DYNAMIC
> 	bool "Dynamic reconfiguration of logging targets"
>-	depends on NETCONSOLE && SYSFS
>-	select CONFIGFS_FS
>+	depends on NETCONSOLE
>+	select NETPOLL_TARGETS_DYNAMIC
> 	help
> 	  This option enables the ability to dynamically reconfigure target
> 	  parameters (interface, IP addresses, port numbers, MAC addresses)
>@@ -3382,7 +3383,16 @@ config NETCONSOLE_DYNAMIC
> 	  See <file:Documentation/networking/netconsole.txt> for details.
> 
> config NETPOLL
>-	def_bool NETCONSOLE
>+	def_bool false
>+
>+config NETPOLL_TARGETS
>+	bool
>+	select NETPOLL
>+
>+config NETPOLL_TARGETS_DYNAMIC
>+	bool
>+	select CONFIGFS_FS
>+	select NETPOLL_TARGETS
> 

Hey, have you tried CONFIG_CONFIGFS_FS=m? :)

Actually, I tried almost the same thing, but finally failed due to
CONFIG_CONFIGFS_FS=m. NETPOLL can't be a module, and configfs can be,
thus you can't use the API provided by configfs.

So, either we need to de-modulize configfs or replace configfs API
with sysfs API. Personally, I prefer the former one, I don't think
configfs should be a module as long as it can provide API's
for other subsystems, like debugfs.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/