linux-kernel - Re: [PATCH 11/19] 8250: Fix tcsetattr to avoid ioctl(TIOCMIWAIT) hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101113174240.2bfb79dd@lxorguk.ukuu.org.uk>
Date:	Sat, 13 Nov 2010 17:42:40 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Greg KH <gregkh@...e.de>
Cc:	Alexey Zaytsev <alexey.zaytsev@...il.com>,
	linux-kernel@...r.kernel.org, Lawrence Rust <lvr@...tsystem.co.uk>
Subject: Re: [PATCH 11/19] 8250: Fix tcsetattr to avoid ioctl(TIOCMIWAIT)
 hang

> Lawrence, any ideas?  If not, I'm going to have to revert this patch
> from the tree.

Peering into the waitqueues like that isn't going to work.

I'd suggest simply keeping a proper count (locked) of the number of
people sitting in TIOCMIWAIT, and probably do it in serial_core (because
the bug doesn't look 8250 specific)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/