linux-kernel - Re: lessen the impact of a deprecated warning in hugetlbfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101113015413.GA2237@dogmatix.scalempus>
Date:	Fri, 12 Nov 2010 17:54:13 -0800
From:	Ravikiran G Thirumalai <kiran@...lex86.org>
To:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: lessen the impact of a deprecated warning in hugetlbfs

It was to be deprecated by 2.6.31. It is better to kill it I think.

Thanks,
Kiran

On Tue, Nov 02, 2010 at 02:06:22PM -0400, Dave Jones wrote:
>WARN_ONCE is a bit strong for a deprecation warning, given that it spews a
>huge backtrace.
>
>Signed-off-by: Dave Jones <davej@...hat.com>
>
>--- linux-2.6.36.noarch/fs/hugetlbfs/inode.c~	2010-11-02 14:01:19.489289082 -0400
>+++ linux-2.6.36.noarch/fs/hugetlbfs/inode.c	2010-11-02 14:02:19.947986439 -0400
>@@ -915,8 +915,7 @@ struct file *hugetlb_file_setup(const ch
> 	if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) {
> 		*user = current_user();
> 		if (user_shm_lock(size, *user)) {
>-			WARN_ONCE(1,
>-			  "Using mlock ulimits for SHM_HUGETLB deprecated\n");
>+			printk_once("Using mlock ulimits for SHM_HUGETLB deprecated\n");
> 		} else {
> 			*user = NULL;
> 			return ERR_PTR(-EPERM);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/