linux-kernel - Re: [RFC/PATCH] usb: Add streams support to epautoconf.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Nov 2010 10:29:15 -0800
From:	Greg KH <greg@...ah.com>
To:	Maya Erez <merez@...eaurora.org>
Cc:	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mike Frysinger <vapier@...too.org>,
	Cliff Cai <cliff.cai@...log.com>,
	Michal Nazarewicz <m.nazarewicz@...sung.com>,
	Fabien Chouteau <fabien.chouteau@...co.com>,
	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH] usb: Add streams support to epautoconf.

On Sun, Nov 14, 2010 at 08:23:20AM +0200, Maya Erez wrote:
> +	/* Get the number of required streams from the EP companion
> +	 * descriptor and see if the EP matches it
> +	 */

Close, but this isn't the proper format for multi-line comments in the
kernel.  Please fix this.

> +	if (USB_ENDPOINT_XFER_BULK == type) {

Ick, no, don't do comparisons like this.  The compiler will let you know
if you acidentally get it wrong with only one '=' character, don't do
things "backward" like this just to work around stupid compilers.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/