linux-kernel - Re: [RFC/PATCH] usb: Add streams support to epautoconf.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1289765733.15533.4.camel@eowin>
Date:	Sun, 14 Nov 2010 22:15:33 +0200
From:	Felipe Balbi <me@...ipebalbi.com>
To:	Greg KH <greg@...ah.com>
Cc:	Maya Erez <merez@...eaurora.org>, linux-usb@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mike Frysinger <vapier@...too.org>,
	Cliff Cai <cliff.cai@...log.com>,
	Michal Nazarewicz <m.nazarewicz@...sung.com>,
	Fabien Chouteau <fabien.chouteau@...co.com>,
	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH] usb: Add streams support to epautoconf.

Hi,

On Sun, 2010-11-14 at 10:29 -0800, Greg KH wrote:
> > +	if (USB_ENDPOINT_XFER_BULK == type) {
> 
> Ick, no, don't do comparisons like this.  The compiler will let you know
> if you acidentally get it wrong with only one '=' character, don't do
> things "backward" like this just to work around stupid compilers.

we actually have helpers for this and usb_endpoint_xfer_bulk(desc)
would do it.

-- 
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/