linux-kernel - Re: [PATCH, RFC] usbmon: correct computing of the ISO packets with mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1011151002060.1606-100000@iolanthe.rowland.org>
Date:	Mon, 15 Nov 2010 10:06:50 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Pete Zaitcev <zaitcev@...hat.com>
cc:	Németh Márton <nm127@...email.hu>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	<linux-usb@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH, RFC] usbmon: correct computing of the ISO packets with
 mmap

On Sun, 14 Nov 2010, Pete Zaitcev wrote:

> On Mon, 15 Nov 2010 06:48:40 +0100
> NÃ©meth MÃ¡rton <nm127@...email.hu> wrote:
> 
> > ev_type == 'S' && usb_urb_dir_out(urb)  ---> data is available, we'll need it
> 
> The write submission case should be covered by the transfer_buffer_length,
> I think. Is there a driver that only sets the ISO descriptors but not
> the overall length?

If there is, it's a bug.  usb_submit_urb() could check for that sort of 
thing -- although so far nobody has complained of problems, so checking 
doesn't seem necessary.

Other things usb_submit_urb() could check for, but currently doesn't, 
include:

	Make sure the packet offsets are non-decreasing;

	Make sure the packet don't overlap in the buffer;

	Make sure the spacing between two consecutive packets
	in the buffer doesn't exceed some upper limit (needed
	by ehci-hcd).

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/