linux-kernel - Re: [PATCH] fix amiga and atari floppy driver compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CE17CF1.3010009@fusionio.com>
Date:	Mon, 15 Nov 2010 19:33:21 +0100
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Vivek Goyal <vgoyal@...hat.com>
CC:	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"linux-m68k@...r.kernel.org" <linux-m68k@...r.kernel.org>,
	"hch@....de" <hch@....de>
Subject: Re: [PATCH] fix amiga and atari floppy driver compile warning

On 2010-11-15 16:27, Vivek Goyal wrote:
> On Thu, Oct 28, 2010 at 02:42:23PM -0400, Vivek Goyal wrote:
>> Geert, my crosstool don't produce warning below. I guess this has to do
>> something with compiler version.
>>
>> - Geert noticed following warning during compilation.
>>
>>   drivers/block/amiflop.c:1344: warning: ‘rq’ may be used uninitialized in
>>   this function
>>   drivers/block/ataflop.c:1402: warning: ‘rq’ may be used uninitialized in
>>   this function
>>
>> - Initialize rq to NULL to fix the warning. If we can't find a suitable request
>>   to dispatch, this function should return NULL instead of a possibly garbage
>>   pointer.
>>
>> - Cross compile tested only. Don't have hardware to test it.
>>
>> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Signed-off-by: Vivek Goyal <vgoyal@...hat.com>
> 
> Hi Jens,
> 
> Do you have any concerns about this patch? If not, can you please apply
> it.

No, it's straight forward just got missed in travel. Applied, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/