linux-kernel - Re: [PATCH] acpi: fix acpi/video.h error and warning when PM is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CE3FD80.7010808@oracle.com>
Date:	Wed, 17 Nov 2010 08:06:24 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Zhang Rui <rui.zhang@...el.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] acpi: fix acpi/video.h error and warning when PM is not
 enabled

On 11/16/10 17:29, Zhang Rui wrote:
> On Wed, 2010-11-17 at 08:59 +0800, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
>> When CONFIG_PM is not enabled, acpi/video.h causes a build error.
>> Also fix a longstanding warning.
>>
>> include/acpi/video.h:22: warning: 'struct acpi_device' declared inside parameter list
>> include/acpi/video.h:22: warning: its scope is only this definition or declaration, which is probably not what you want
>> include/acpi/video.h: In function 'acpi_video_get_edid':
>> include/acpi/video.h:24: error: 'ENODEV' undeclared (first use in this function)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> 
> we already have a patch at
> http://marc.info/?l=linux-kernel&m=128369371631933&w=2
> Not sure if Len has applied it or not.
> Anyway, thanks for the patch. :)

Good.  Thanks for the info.

> -rui
>> ---
>>  include/acpi/video.h |    4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> --- lnx-2637-rc2.orig/include/acpi/video.h
>> +++ lnx-2637-rc2/include/acpi/video.h
>> @@ -1,6 +1,10 @@
>>  #ifndef __ACPI_VIDEO_H
>>  #define __ACPI_VIDEO_H
>>  
>> +#include <linux/errno.h>
>> +
>> +struct acpi_device;
>> +
>>  #define ACPI_VIDEO_DISPLAY_CRT  1
>>  #define ACPI_VIDEO_DISPLAY_TV   2
>>  #define ACPI_VIDEO_DISPLAY_DVI  3
>> --


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/