| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4CE3B547.7050907@fusionio.com> Date: Wed, 17 Nov 2010 11:58:15 +0100 From: Jens Axboe <jaxboe@...ionio.com> To: Linus Torvalds <torvalds@...ux-foundation.org> CC: Randy Dunlap <randy.dunlap@...cle.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] cciss: fix build for PROC_FS disabled On 2010-11-17 03:56, Linus Torvalds wrote: > On Tue, Nov 16, 2010 at 5:00 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote: >> >> Fix cciss driver for CONFIG_PROC_FS not enabled: >> >> drivers/block/cciss.c:4929: error: 'proc_cciss' undeclared (first use in this function) > > Hmm. I would almost prefer to not have this #ifdef inside code, and > solve it by simply moving the definition of "proc_cciss" to outside > the other #ifdef CONFIG_PROC_FS. > > That way it allways stays NULL, and without CONFIG_PROC_FS the code in > question will all be empty inline function calls anyway, so the > compiler will compile it all away (at the cost of just keeping that > one unnecessary variable around). > > I'd rather waste one useless pointer than have ugly source code. > > Comments? Agree, I merged this: http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=bbe425cd9ae83eacd0c9f09df2bf56dc911a54cd -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists