linux-kernel - Re: [PATCH 2/3] staging: ft1000: Remove unused char dev inerface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinEvAXRGdgoWfzRx3Q8xSfkuTLhn21AoV3iz0ih@mail.gmail.com>
Date:	Thu, 18 Nov 2010 09:43:00 +0100
From:	Belisko Marek <marek.belisko@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: ft1000: Remove unused char dev inerface.

Hi Greg,

On Tue, Nov 16, 2010 at 8:36 PM, Greg KH <greg@...ah.com> wrote:
> On Sat, Nov 13, 2010 at 08:05:40PM +0100, Belisko Marek wrote:
>> Hi Greg,
>>
>> On Thu, Nov 11, 2010 at 1:26 AM, Greg KH <greg@...ah.com> wrote:
>> > On Wed, Nov 10, 2010 at 11:15:27AM +0100, Marek Belisko wrote:
>> >> This patch remove lot of code for character device. This
>> >> interface was used for getting network informations and
>> >> statistics which is currently exported via /proc filesystem.
>> >>
>> >> Signed-off-by: Marek Belisko <marek.belisko@...il.com>
>> >
>> > This patch does not apply :(
>> I'm trying to resend but need to wait till linux-next will sync with
>> linus kernel.
>> In mainline there is a patch (61241d97db02559bd83d21ffa783ab327945b925) which
>> is not in linux-next.
>>
>> I try to apply patch for mainline but it failed. I'll fix and resend then.
>> Hopefully this is correct if not forgive me ;)
>
> Everything should be synced up now, please resync and resend.
I'll change my mind and from this patch series I'll resend just 1/3 patch.
Patch 2/3 (followed by 3/3) is maybe not correct because it completely
remove access to
device from user space through /dev interface (used for debugging and testing).

My first idea was just remove it completely because we have a device which just
connect to network and don't need to have some debug interface.

Anyway I'll change creation of device in kernel via kernel threads
which is not from my
point of view correct.

>
> thanks,
>
> greg k-h
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/