linux-kernel - Re: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mapping early during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101118090828.GA28467@elte.hu>
Date:	Thu, 18 Nov 2010 10:08:28 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
	hpa@...or.com, x86@...nel.org, eric.dumazet@...il.com,
	yinghai@...nel.org
Subject: Re: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid
 mapping early during boot


* Tejun Heo <tj@...nel.org> wrote:

> Hello,
> 
> On 11/18/2010 09:42 AM, Ingo Molnar wrote:
> > This is a very sensitive area of code that tends to blow up in nasty
> > ways. So when we do changes here we want them super-finegrained. If
> > you split it up into 30 reasonable patches - no problem at
> > all. (here up to 5 would suffice i think)
> 
> I'll probably split it to three or four.  That said, I don't really
> think it would help bisection.  But, anyways, no problem.

The most critical patch will of course be the most likely one to regress so a 
split-up does not help bisection per se.

The help this does for us is _fixing_ stuff: we will be looking at a 20 lines patch, 
not a 200 lines one ...

> [...] For now, I would suggest leaving them ugly.  At least
> they're now properly localized after the patchset.

ok. Please add a comment declaring the ugliness and explaining why they are ugly - 
so that future hackers see it as an exception to the rule, not as an example to 
follow ;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/