linux-kernel - Re: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mapping early during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CE4E841.9020107@kernel.org>
Date:	Thu, 18 Nov 2010 09:48:01 +0100
From:	Tejun Heo <tj@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	linux-kernel@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
	hpa@...or.com, x86@...nel.org, eric.dumazet@...il.com,
	yinghai@...nel.org
Subject: Re: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mapping
 early during boot

Hello,

On 11/18/2010 09:42 AM, Ingo Molnar wrote:
> This is a very sensitive area of code that tends to blow up in nasty
> ways. So when we do changes here we want them super-finegrained. If
> you split it up into 30 reasonable patches - no problem at
> all. (here up to 5 would suffice i think)

I'll probably split it to three or four.  That said, I don't really
think it would help bisection.  But, anyways, no problem.

>> Yeah, what they do is ugly.  It gets less uglier after the patchset.
>> I'll see if some of them can be dropped but I don't think putting them
>> inside ifdef'd inline functions necessarily improves things.  It often
>> just makes things more difficult to follow.
> 
> Can we remove them? Or does it make any sense on the 64-bit side?

Those are the parts where 32 and 64 actually differ.  On 64, the
mapping between physical and logical are fixed (at least in the
generic arch code) which isn't true on 32, so it doesn't make much
sense for 64.  For now, I would suggest leaving them ugly.  At least
they're now properly localized after the patchset.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/