linux-kernel - Re: [PATCH] mm: remove call to find_vma in pagewalk for non-hugetlbfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101119113503.GF28613@csn.ul.ie>
Date:	Fri, 19 Nov 2010 11:35:03 +0000
From:	Mel Gorman <mel@....ul.ie>
To:	David Sterba <dsterba@...e.cz>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Andy Whitcroft <apw@...onical.com>,
	David Rientjes <rientjes@...gle.com>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	Lee Schermerhorn <lee.schermerhorn@...com>,
	Matt Mackall <mpm@...enic.com>,
	Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [PATCH] mm: remove call to find_vma in pagewalk for
	non-hugetlbfs

On Fri, Nov 19, 2010 at 01:39:57AM +0100, David Sterba wrote:
> Commit d33b9f45 introduces a check if a vma is a hugetlbfs one and
> later in 5dc37642 is moved under #ifdef CONFIG_HUGETLB_PAGE but
> a needless find_vma call is left behind and it's result not used
> anywhere else in the function.
> 
> The sideefect of caching vma for @addr inside walk->mm is neither
> utilized in walk_page_range() nor in called functions.
> 
> Signed-off-by: David Sterba <dsterba@...e.cz>
> Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Andy Whitcroft <apw@...onical.com>
> Cc: David Rientjes <rientjes@...gle.com>
> Cc: Hugh Dickins <hugh.dickins@...cali.co.uk>
> Cc: Lee Schermerhorn <lee.schermerhorn@...com>
> Cc: Matt Mackall <mpm@...enic.com>
> Cc: Mel Gorman <mel@....ul.ie>
> Cc: Wu Fengguang <fengguang.wu@...el.com>

Well spotted.

Acked-by: Mel Gorman <mel@....ul.ie>

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/