lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Nov 2010 14:09:17 -0600 From: Matt Mackall <mpm@...enic.com> To: David Sterba <dsterba@...e.cz> Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, Naoya Horiguchi <n-horiguchi@...jp.nec.com>, Andi Kleen <ak@...ux.intel.com>, Andy Whitcroft <apw@...onical.com>, David Rientjes <rientjes@...gle.com>, Hugh Dickins <hugh.dickins@...cali.co.uk>, Lee Schermerhorn <lee.schermerhorn@...com>, Mel Gorman <mel@....ul.ie>, Wu Fengguang <fengguang.wu@...el.com> Subject: Re: [PATCH] mm: remove call to find_vma in pagewalk for non-hugetlbfs On Fri, 2010-11-19 at 01:39 +0100, David Sterba wrote: > Commit d33b9f45 introduces a check if a vma is a hugetlbfs one and > later in 5dc37642 is moved under #ifdef CONFIG_HUGETLB_PAGE but > a needless find_vma call is left behind and it's result not used > anywhere else in the function. > > The sideefect of caching vma for @addr inside walk->mm is neither > utilized in walk_page_range() nor in called functions. Looks good to me. Acked-by: Matt Mackall <mpm@...enic.com> -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists