linux-kernel - Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1011191053040.10560@gbean-linux.qualcomm.com>
Date:	Fri, 19 Nov 2010 11:00:32 -0800 (PST)
From:	Gregory Bean <gbean@...eaurora.org>
To:	Janakiram Sistla <janakiram.sistla@...il.com>
cc:	Gregory Bean <gbean@...eaurora.org>, dwalker@...eaurora.org,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

>>>> Targets with the v2 block define CONFIG_MSM_V2_TLMM.
>>>
>>> So in that case we can name  it as gpio-tlmm.c ??
>>
>> No, not and have things be any clearer.
>>
>> All MSM chips have a TLMM block.  The older chips have
>> version 1 (v1) of the TLMM block.  The newer chips have v2.
>
> I think that we should differentiate the new gpio infrastructure with
> appropriate naming that makes the diff between v1 and v2

What do you suggest?  All MSM SoCs have a TLMM block.  The block itself
carries no model or revision name, and is not tied specifically to any
particular SoC, except for the fact that the second generation of this block
happened to appear at the same time as the MSM8x60.

gpio.c is already in wide use for v1 systems, and is well-establised
in the android mainlines.  Changing without extremely good cause would not
go pleasantly.

Since gpio.c is v1, we used gpio-v2.c for v2.

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.