linux-kernel - Re: [PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <616676.83025.qm@web180301.mail.gq1.yahoo.com>
Date:	Sat, 20 Nov 2010 14:59:28 -0800 (PST)
From:	David Brownell <david-b@...bell.net>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Patrice Vilchez <patrice.vilchez@...el.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map_xfer'



--- On Sat, 11/20/10, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:

> > +        void
> *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */

Reads like a bad patch to me. Fix the bug,
don't just silence GCC.  Or at least use
a better comment mentioning a constness
cast problems).

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/