[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20101121021934.GH4216@game.jcrosoft.org>
Date: Sun, 21 Nov 2010 03:19:34 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To: David Brownell <david-b@...bell.net>
Cc: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>,
Nicolas Ferre <nicolas.ferre@...el.com>,
Patrice Vilchez <patrice.vilchez@...el.com>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH 6/6] atmel_spi: fix warning In function
'atmel_spi_dma_map_xfer'
On 14:59 Sat 20 Nov , David Brownell wrote:
>
>
> --- On Sat, 11/20/10, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
>
> > > + void
> > *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */
>
> Reads like a bad patch to me. Fix the bug,
> don't just silence GCC. Or at least use
> a better comment mentioning a constness
> cast problems).
ok I change the comment
Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists