linux-kernel - Re: [PATCH] ARM: Fix spinlock bad magic on disabling nonboot cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=d2xL_ZDhQtTE9Vt8SQkHGSM5oespHGT4m6Fav@mail.gmail.com>
Date:	Sat, 20 Nov 2010 12:02:47 +0900
From:	Kyungmin Park <kmpark@...radead.org>
To:	Colin Cross <ccross@...roid.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	linux-kernel@...r.kernel.org,
	함명주 <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] ARM: Fix spinlock bad magic on disabling nonboot cpu

Hi,

I wonder why this patch is not merged previous rc cycles.

it's already reported by Mr. Ham (a month or more ago) and get some
acked for merge.

To Rusell, Catalin,
How to include or commit the latest kernel?

Thank you,
Kyungmin Park

On Sat, Nov 20, 2010 at 11:16 AM, Colin Cross <ccross@...roid.com> wrote:
> The init_mm.context.id_lock spinlock is not initialized, which
> causes a spinlock bad magic warning when nonboot cpus are disabled,
> either through hotplug or during suspend.
>
> Signed-off-by: Colin Cross <ccross@...roid.com>
> ---
>  arch/arm/include/asm/mmu.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/mmu.h b/arch/arm/include/asm/mmu.h
> index 68870c7..1556f6a 100644
> --- a/arch/arm/include/asm/mmu.h
> +++ b/arch/arm/include/asm/mmu.h
> @@ -13,6 +13,8 @@ typedef struct {
>
>  #ifdef CONFIG_CPU_HAS_ASID
>  #define ASID(mm)       ((mm)->context.id & 255)
> +#define INIT_MM_CONTEXT(name)                                                 \
> +        .context.id_lock = __SPIN_LOCK_UNLOCKED(name.context.id_lock),
>  #else
>  #define ASID(mm)       (0)
>  #endif
> --
> 1.7.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/