linux-kernel - Re: [PATCH] video: arcfb: fix buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101124062558.GF11705@linux-sh.org>
Date:	Wed, 24 Nov 2010 15:25:58 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Vasiliy Kulikov <segoon@...nwall.com>
Cc:	kernel-janitors@...r.kernel.org, Jaya Kumar <jayalk@...works.biz>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: arcfb: fix buffer overflow

On Sun, Nov 21, 2010 at 08:40:01PM +0300, Vasiliy Kulikov wrote:
> (count + p) is not checked for integer overflow.  If p < fbmemlength
> and count == (size_t)(1 - p) (very big unsigned integer) then
> count + p == 1 < fbmemlength and copy_to_user(base_addr+p, buf, count)
> overflows base_addr.
> 
> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/